File download using node

Thank you for showing example using request module. Show 3 more comments. MikeL 5, 38 38 silver badges 41 41 bronze badges.

Augusto Roman Augusto Roman 6 6 silver badges 4 4 bronze badges. What for are you storing request into a variable? You are right, there is no need to save the request, its not used anyway.

That's what you mean? Yes, I think that's what polkovnikov. Per default the fs. Bjarke Pjedsted Bjarke Pjedsted 4 4 silver badges 8 8 bronze badges.

Two comments on this: 1 it should probably reject Error objects, not strings, 2 fs. This works great! No errors popped up but the. Removing the logic for the flag fixed it. Just wanted to point that out if someone had the issues with the approach. Is there a memory leak in this answer: stackoverflow.

You can add timeout like I did in http. The memory leak is only if the file take too long to be downloaded. Based on the other answers above and some subtle issues, here is my attempt. Check the file does not exist before hitting the network by using fs. Only create the fs. This reduces the amount of fs. Even on a OK we can still possibly reject due to an EEXIST file already exists imagine another process created the file whilst we were doing network calls.

Recursively call download if you get a Moved Permanently or Found Moved Temporarily redirect following the link location provided in the header. The issue with some of the other answers recursively calling download was that they called resolve download instead of download This way the nested chain of promises resolve in the correct order.

It might seem cool to clean up the temp file asynchronously, but I chose to reject only after that completed too so I know that everything start to finish is done when this promise resolves or rejects. Josh Peak Josh Peak 4, 4 4 gold badges 33 33 silver badges 48 48 bronze badges.

You shouldn't waste resources doing the download if the destination file already exists. Do the check first if possible. Phil Really good point. I have updated the example with an earlier guard check before falling into the recursive networking calls but left the success file handling code the same. This short circuit guard statement should save some time in this case now.

Vince Yuan's code is great but it seems to be something wrong. But we don't check the result if callback callback err. Feel Physics Feel Physics 2, 4 4 gold badges 23 23 silver badges 36 36 bronze badges.

I prefer request because you can use both http and https with it. Looks like Request has been deprecated github. No new changes are expected to land. In fact, none have landed for some time. Wai Ha Lee 7, 61 61 gold badges 56 56 silver badges 85 85 bronze badges. Idan Dagan Idan Dagan 7, 3 3 gold badges 28 28 silver badges 38 38 bronze badges.

Handle this scenario as well. Axios has great support for file downloads. Adjust the file download with Axios to your needs. We love to hear your thoughts and ideas. Get your weekly push notification about new and trending Future Studio content and recent platform enhancements. Marcus is a fullstack JS developer.

Collectives on Stack Overflow. Learn more. How to download an. Asked 14 days ago. Active 14 days ago. Viewed 29 times. Gianlucca Claudino Gianlucca Claudino 3 1 1 bronze badge. Add a comment. Active Oldest Votes. The physical file is being generated empty for some reason. This actually solved the problem, the problem I'm facing now is that when the file is downloaded outside of the client, it is returned without the data — Gianlucca Claudino.

Kotlin Split String example. Follow us Facebook Youtube Github. Tools Json Formatter. We use cookies to improve your experience with the site.

Close Privacy Overview This website uses cookies to improve your experience while you navigate through the website. Out of these cookies, the cookies that are categorized as necessary are stored on your browser as they are essential for the working of basic functionalities of the website. We also use third-party cookies that help us analyze and understand how you use this website.